search

trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
534 stars 108 forks source link

Remove redundant rebalancing of P4estMesh #622

Open efaulhaber opened 3 years ago

efaulhaber commented 3 years ago

Once https://github.com/cburstedde/p4est/issues/112 is fixed, we should remove redundant calls to p4est_balance like in code like this: https://github.com/trixi-framework/Trixi.jl/blob/dd5e28e03cffcc391a4ca9536a498613c0c6ecd4/src/solvers/dg_p4est/dg.jl#L7-L10

efaulhaber commented 1 year ago

See updates in https://github.com/cburstedde/p4est/issues/112#issuecomment-1729148458. It appears that the way we currently set up the connectivity is not supported, and that we should also set up corner connectivity, even though we don't need that for DG. That should make this double rebalancing redundant.

This is definitely more work on our side, but from these comments, it seems that our current approach might break one day when they start relying more heavily on corner connectivity.