search

trixi-framework / Trixi.jl

Trixi.jl: Adaptive high-order numerical simulations of conservation laws in Julia
https://trixi-framework.github.io/Trixi.jl
MIT License
523 stars 103 forks source link

Coverage reports don't show elixirs #654

Open efaulhaber opened 3 years ago

efaulhaber commented 3 years ago

I noticed a few problems with the coverage reports.

  1. In Coveralls, the default branch is still set to master.
  2. Most code in elixir files doesn't count as covered/uncovered code. The only lines that count are the function definitions of CurvedMesh and P4estMesh. I guess that this has nothing to do with Coveralls or Codecov but with Julia's coverage tools directly. Both Coveralls and Codecov report most elixirs as having no code lines at all.
ranocha commented 3 years ago
  1. In Coveralls, the default branch is still set to master.

Where do you see that? If I click on the link of the badge in the README.md, I see the main branch on Coveralls.

ranocha commented 3 years ago

2. Most code in elixir files doesn't count as covered/uncovered code. The only lines that count are the function definitions of CurvedMesh and P4estMesh. I guess that this has nothing to do with Coveralls or Codecov but with Julia's coverage tools directly. Both Coveralls and Codecov report most elixirs as having no code lines at all.

Yeah, that's unfortunate...

efaulhaber commented 3 years ago

In Coveralls, the default branch is still set to master.

Where do you see that? If I click on the link of the badge in the README.md, I see the main branch on Coveralls.

That's weird, I opened a report earlier today, and it showed me master. Now, opening the same report shows main.

Edit: I still have the tab open, and it shows this: grafik After refreshing the page, it shows main, so that seems to be updated now.

ranocha commented 3 years ago

Okay, at least that part seems to be fixed magically :sweat_smile: