search

trixi-framework / TrixiAtmo.jl

Simulation package for atmospheric models based on Trixi.jl
MIT License
7 stars 0 forks source link

Merging `thesis_gemein_2022` into `TrixiAtmo.jl` #1

Closed Arpit-Babbar closed 3 weeks ago

Arpit-Babbar commented 2 months ago

In the branch https://github.com/trixi-framework/TrixiAtmo.jl/tree/ab_lucas, I am trying to add the results from https://github.com/NichtLucas/Trixi.jl/tree/thesis_gemein_2022 using Trixi as a dependency.

Here is the $v_2$ velocity plot from the elixir https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/examples/elixir_moist_euler_nonhydrostatic_gravity_waves.jl

image

I have not made any changes to the internals of the code from https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/examples/elixir_moist_euler_nonhydrostatic_gravity_waves.jl, just added import and using as needed. We could do some more tests for validation. If things are okay, we can decide how to merge this into main (how to break into PRs and review).

sloede commented 2 months ago

Nice work! Can you please create a draft PR such that we can see how much code would have to be merged, in order to make an informed decision?

tristanmontoya commented 3 weeks ago

Completed in #2.