trixi-framework / TrixiAtmo.jl

Simulation package for atmospheric models based on Trixi.jl
MIT License
8 stars 1 forks source link

Merging `thesis_gemein_2022` into `TrixiAtmo.jl` #2

Closed Arpit-Babbar closed 2 months ago

Arpit-Babbar commented 3 months ago

This PR started as an explanation to https://github.com/trixi-framework/TrixiAtmo.jl/issues/1. Now, it adds all the elixirs with respective CI tests from Lucas' thesis.

TODO

tristanmontoya commented 3 months ago

This is a good start for TrixiAtmo.jl, and should be quite useful. I will have some time to look into the specifics more in the next week, but my first thought is that we should perhaps set up testing/CI (similarly to TrixiShallowWater.jl) before merging this to main.

github-actions[bot] commented 3 months ago

Pull Request Test Coverage Report for Build 9959365955

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/equations/compressible_moist_euler_2d.jl 0 567 0.0%
<!-- Total: 0 567 0.0% -->
Totals Coverage Status
Change from base Build 9959098082: -99.3%
Covered Lines: 4
Relevant Lines: 571

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9970231868

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/equations/compressible_moist_euler_2d.jl 211 568 37.15%
<!-- Total: 211 568 37.15% -->
Totals Coverage Status
Change from base Build 9959098082: -62.4%
Covered Lines: 215
Relevant Lines: 572

💛 - Coveralls
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 73.76761% with 149 lines in your changes missing coverage. Please review.

Project coverage is 50.90%. Comparing base (1c7efd9) to head (5f91de5). Report is 1 commits behind head on main.

Files Patch % Lines
src/equations/compressible_moist_euler_2d_lucas.jl 73.76% 149 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2 +/- ## =========================================== + Coverage 19.34% 50.90% +31.55% =========================================== Files 8 8 Lines 827 827 =========================================== + Hits 160 421 +261 + Misses 667 406 -261 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benegee commented 3 months ago

At first I though that we could maybe move some parts to TrixiBase.jl, but then I realized that these macro e.g. explicitly include the Trixi. Maybe we should therefore just add our own macros as need be.

benegee commented 3 months ago
  • Are the 1920 allocations expected?

Which test case was it?

ranocha commented 2 months ago

It looks good to me, although I am wondering if either of you (@Arpit-Babbar or @benegee) know the reason for the warnings copied below? My tests have always been very simple so I've never run into this.

WARNING: replacing module TrixiAtmoTestModule. WARNING: could not import TestExamples2DMoistEuler.TRIXI_EXAMPLES_DIR into TrixiAtmoTestModule

You define a module with the same name every time in

https://github.com/trixi-framework/TrixiAtmo.jl/blob/1c7efd9be9a80019df8d74bb765ffdccd6a90ba1/test/test_trixiatmo.jl#L28

If you want to get rid of that warning, you could gensym an appropriate name - but I don't think that's necessary right now.