search

trixi-framework / TrixiBase.jl

Common functionality used by multiple Julia packages in the Trixi Framework
https://trixi-framework.github.io/TrixiBase.jl/
MIT License
5 stars 3 forks source link

Initial development #1

Closed sloede closed 8 months ago

sloede commented 9 months ago

This PR is intended to include all basic package infrastructure to make this a proper Julia package and should, once satisfactory, merged using a squash merge.

codecov-commenter commented 9 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

efaulhaber commented 9 months ago

What is this Windows error?

efaulhaber commented 9 months ago

And what is macOS doing?

efaulhaber commented 8 months ago

Any more suggestions? It seems to be the second line now. Neither

julia -e 'using JuliaFormatter; !format(".", verbose=true) &&
            error("Code not properly formatted")'

nor

julia -e "using JuliaFormatter; !format(\".\", verbose=true) &&
            error(\"Code not properly formatted\")"

seem to work.

efaulhaber commented 8 months ago

How is it not properly formatted now?

efaulhaber commented 8 months ago

Finally...

ranocha commented 8 months ago

@sloede, @efaulhaber Fine with you?

efaulhaber commented 8 months ago

Merge?

ranocha commented 8 months ago

Fine with me. @sloede?

sloede commented 8 months ago

Thanks a lot for preparing this, @efaulhaber!