trixi-framework / TrixiBase.jl

Common functionality used by multiple Julia packages in the Trixi Framework
https://trixi-framework.github.io/TrixiBase.jl/
MIT License
5 stars 3 forks source link

Format error shouldn't prevent tests from running #4

Closed sloede closed 8 months ago

sloede commented 8 months ago

What's the rationale behind stopping all tests if the format is wrong? My dev workflow is often incremental, thus I do a little thing, push, then come back later once tests have run. If the only thing missing the formatting while all functional tests are green, I usually just apply the formatter and immediately request a review.

IMHO, we should either make the format check a separate run on a single OS, or move it to the end of the tests. I prefer the former. Thoughts @efaulhaber @ranocha ?

ranocha commented 8 months ago

I also prefer the first option. IIRC, @efaulhaber told me that he uses it like it is since that saves CI time in private repositories - fail fast if anything isn't correct.

efaulhaber commented 8 months ago

Yes, that's what we use for TrixiParticles to avoid wasting CI time when the run will fail anyway.