Closed ranocha closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1dc5a93
) 93.65% compared to head (8bebfd9
) 94.36%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ranocha I think the error message is not yet properly filtered out: https://github.com/trixi-framework/TrixiBase.jl/actions/runs/7711136543/job/21015911732?pr=5#step:7:65
Totals | |
---|---|
Change from base Build 7711120067: | 0.7% |
Covered Lines: | 67 |
Relevant Lines: | 71 |
@ranocha I think the error message is not yet properly filtered out: https://github.com/trixi-framework/TrixiBase.jl/actions/runs/7711136543/job/21015911732?pr=5#step:7:65
Should be fixed
I wanted to draft a version with a package extension for MPI so that we can still include the info message
However, the first naive approach doesn't work nicely since we're not allowed to overwrite method definitions while precompiling. Thus, I needed to deactivate precompilation for the extension, resulting in the ugly messages
We can not use something in
__init__
since that will be called before Trixi.jl is initialized - i.e., before MPI is initialized in general.