search

trixi-framework / TrixiParticles.jl

TrixiParticles.jl: Particle-based multiphysics simulations in Julia
https://trixi-framework.github.io/TrixiParticles.jl/
MIT License
33 stars 10 forks source link

Replace externally hosted images #274

Open efaulhaber opened 12 months ago

efaulhaber commented 12 months ago

In #272, I added images that I hosted externally because images uploaded directly to the repo can (apparently) only be embedded by using a temporary token. I guess we should host all images externally for now, but still upload them to docs/src/assets. Once we go public, this issue should be a reminder to replace all of these links.

sloede commented 12 months ago

I recommend to not upload binary blobs to this repo, as these are hard to compress, often quickly outdated, and are not really "code". In Trixi.jl, we for example collect funding agency logos in a dedicated issue (https://github.com/trixi-framework/Trixi.jl/issues/1390) - maybe this model works here as well?

svchb commented 12 months ago

Yes we have already discussed this on slack. This currently doesn't work since it will generate private links which cannot be linked to even within the project. Erik has also removed the pictures from his PR as well. @efaulhaber: So I guess we can close this again?

efaulhaber commented 12 months ago

We still have to host all images externally for now, so we keep this PR open as a reminder to replace them with GitHub links once we're public.