search

trixi-framework / TrixiParticles.jl

TrixiParticles.jl: Particle-based multiphysics simulations in Julia
https://trixi-framework.github.io/TrixiParticles.jl/
MIT License
33 stars 10 forks source link

Inline viscosity #578

Closed efaulhaber closed 4 months ago

efaulhaber commented 4 months ago

Okay, hear me out. This is a 1.4-1.5x speedup in the fluid-fluid interact, just by inlining dv_viscosity. Don't ask me why the difference is so extreme.

grafik
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@b3219cb). Learn more about missing BASE report. Report is 1 commits behind head on main.

Files Patch % Lines
src/schemes/fluid/viscosity.jl 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #578 +/- ## ======================================= Coverage ? 69.73% ======================================= Files ? 76 Lines ? 4573 Branches ? 0 ======================================= Hits ? 3189 Misses ? 1384 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/TrixiParticles.jl/pull/578/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/trixi-framework/TrixiParticles.jl/pull/578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `69.73% <66.66%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.