codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
Project coverage is 69.92%. Comparing base (
33f6f86) to head (915d652). Report is 2 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...oundary/open_boundary/method_of_characteristics.jl | 50.00% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #605 +/- ## ========================================== + Coverage 69.90% 69.92% +0.02% ========================================== Files 86 86 Lines 5123 5124 +1 ========================================== + Hits 3581 3583 +2 + Misses 1542 1541 -1 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/TrixiParticles.jl/pull/605/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/trixi-framework/TrixiParticles.jl/pull/605/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `69.92% <50.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Saving sound speed in the openboundary system makes no sense especially in the context of multiple fluids that can be at the openboundary. As such remove sound speed and reuse the information from the fluid system(s).
Extracted from #604