search

trixi-framework / TrixiParticles.jl

TrixiParticles.jl: Particle-based multiphysics simulations in Julia
https://trixi-framework.github.io/TrixiParticles.jl/
MIT License
33 stars 10 forks source link

Fixes for Open Boundary Systems for free surfaces #609

Closed svchb closed 19 hours ago

svchb commented 2 months ago

Depends on #610 Depends on #608 Depends on #606 Depends on #605 Depends on #603 Depends on #599

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (dd75d48) to head (0dab347). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...oundary/open_boundary/method_of_characteristics.jl 44.44% 5 Missing :warning:
src/schemes/boundary/open_boundary/system.jl 69.23% 4 Missing :warning:
...c/schemes/boundary/open_boundary/boundary_zones.jl 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #609 +/- ## ========================================== - Coverage 68.74% 68.71% -0.04% ========================================== Files 86 86 Lines 5282 5299 +17 ========================================== + Hits 3631 3641 +10 - Misses 1651 1658 +7 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/TrixiParticles.jl/pull/609/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/trixi-framework/TrixiParticles.jl/pull/609/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `68.71% <66.66%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

svchb commented 1 month ago

Note there were other things in this PR most have been reverted since it is was not leading anywhere. Or it was conflicting with #623