trixi-framework / TrixiParticles.jl

TrixiParticles.jl: Particle-based multiphysics simulations in Julia
https://trixi-framework.github.io/TrixiParticles.jl/
MIT License
33 stars 10 forks source link

CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat) #622

Closed github-actions[bot] closed 3 weeks ago

github-actions[bot] commented 1 month ago

This pull request changes the compat entry for the DiffEqCallbacks package from 2.25, 3 to 2.25, 3, 4. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.37%. Comparing base (eb9f41b) to head (62be165). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #622 +/- ## ======================================= Coverage 69.37% 69.37% ======================================= Files 85 85 Lines 5124 5124 ======================================= Hits 3555 3555 Misses 1569 1569 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/TrixiParticles.jl/pull/622/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/trixi-framework/TrixiParticles.jl/pull/622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `69.37% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sloede commented 1 month ago

The tests pass, but they still seem to be using DiffEqCallbacks v3.8.0.

svchb commented 1 month ago

I did run the tests again still 3.8.0.

svchb commented 1 month ago

Still not being used even with 1.11

svchb commented 3 weeks ago

Done in #632

efaulhaber commented 3 weeks ago

We should keep in mind that the tests are still using 3 instead of 4.

svchb commented 3 weeks ago

I checked we are not using any of the changed features at the moment.