search

trixi-framework / libtrixi

Interface library for using Trixi.jl from C/C++/Fortran
https://trixi-framework.github.io/libtrixi/
MIT License
3 stars 1 forks source link

Swap installation order of Trixi.jl and LibTrixi.jl #192

Closed benegee closed 2 months ago

benegee commented 3 months ago

Does this fix #190 ?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.27%. Comparing base (25d7014) to head (a5cb439). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ======================================= Coverage 80.27% 80.27% ======================================= Files 19 19 Lines 715 715 Branches 50 50 ======================================= Hits 574 574 Misses 137 137 Partials 4 4 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/libtrixi/pull/192/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/libtrixi/pull/192/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `80.27% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benegee commented 3 months ago

I also updated t8code's version to v2.0.0. Should have done that earlier, but it also seems to be necessary with the current version of Trixi.jl.

benegee commented 3 months ago

:roll_eyes: https://github.com/trixi-framework/Trixi.jl/pull/1865 (which happens to be my own PR) changed the non-public-API nelementsglobal.

What to do? Restrict Trixi.jl version to >=0.7.16?

sloede commented 3 months ago

🙄 trixi-framework/Trixi.jl#1865 (which happens to be my own PR) changed the non-public-API nelementsglobal.

What to do? Restrict Trixi.jl version to >=0.7.16?

What do you mean? All tests seem to pass?!