search

trixi-framework / libtrixi

Interface library for using Trixi.jl from C/C++/Fortran
https://trixi-framework.github.io/libtrixi/
MIT License
3 stars 1 forks source link

Move to new t8code version 3.0.0 #215

Closed benegee closed 2 weeks ago

benegee commented 3 weeks ago
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.75%. Comparing base (dd3cce5) to head (2ae6191). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #215 +/- ## ========================================== + Coverage 80.52% 81.75% +1.23% ========================================== Files 19 21 +2 Lines 724 773 +49 Branches 50 52 +2 ========================================== + Hits 583 632 +49 Misses 137 137 Partials 4 4 ``` | [Flag](https://app.codecov.io/gh/trixi-framework/libtrixi/pull/215/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trixi-framework/libtrixi/pull/215/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework) | `81.75% <100.00%> (+1.23%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trixi-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benegee commented 2 weeks ago

It's been a while, but we have something to review @sloede !

Note that PackageCompiler build currently fails but will be fixed in course of https://github.com/trixi-framework/libtrixi/pull/207 hereafter.

benegee commented 2 weeks ago

Another ping @sloede as requested. :smiley:

benegee commented 2 weeks ago

Generally LGTM, just a few questions. Also, some tests seem to be failing?

This is package compiler and will hopefully be fixed in course of https://github.com/trixi-framework/libtrixi/pull/207 hereafter.