search

trizen / clyrics

An extensible lyrics fetcher, with daemon support for cmus and mocp.
https://trizenx.blogspot.com/2013/02/mocp-lyrics.html
GNU General Public License v3.0
56 stars 15 forks source link

Decode HTML entities for all plugins #4

Closed natezb closed 7 years ago

natezb commented 7 years ago

Nice work on clyrics, I really like it!

Currently only 4 of the plugins call decode_entities on the text they return, so I've noticed encoded HTML entities in some fetched lyrics.

Tell me if I'm wrong, but I think it would probably make the most sense to do the decoding in get_lyrics() instead, so that it gets applied to all the plugins automatically.

trizen commented 7 years ago

Your suggestion is actually very good and I applied it in the above commit. Thank you! :+1: