search

trlinkin / puppet-nsswitch

Puppet module to control /etc/nsswitch.conf file.
Other
2 stars 34 forks source link

Added support for CloudLinux #16

Closed marknl closed 8 years ago

marknl commented 8 years ago

nsswitch.conf looks (by default) the most on the ones that are supplied by Debian/Ubuntu, therefor I placed it there (Though CL is actually a CentOS based distro).

trlinkin commented 8 years ago

@marknl Awesome thanks. Could you please update the spec tests to include this as well.

marknl commented 8 years ago

Fixed.

trlinkin commented 8 years ago

Thanks for adding the tests. I'm going to spin up a cloudlinux instance and check it out, and then probably accept.

trlinkin commented 8 years ago

Also for the future @marknl, please make slightly more descriptive commit messages. Three messages with the same exact subject line don't provide a lot of detail and erode the value of having a commit history.

marknl commented 8 years ago

Will do!

trlinkin commented 8 years ago

@marknl I spun up a cloud linux 7.0 instance and it's nsswitch looks by default like the centos one with the addition of sss for about five of the services.

Which versions of cloud linux did you test against?

trlinkin commented 8 years ago

Just loaded up a cloud Linux 6.6 instance too, and it's nsswitch looks exactly like the Centos/Rhel section. I think I need to check back and differentiate between EL 6 and EL 7.

trlinkin commented 8 years ago

So yeah, just checked. Cloudlinux appears to actually follow the Enterprise Linux patterns. What I do need to do however is update to account for EL 6 vs 7.

If I'm missing something critical @marknl please let me know.

marknl commented 8 years ago

Hmm, strange .. Maybe my co-worker(s) changed the layout of the nsswitch.conf file. I'll double check it at work tomorrow and let you know.

edit: we're running CL6

trlinkin commented 8 years ago

@marknl I'm going to close this for now and add CloudLinux as one of the EL platforms since all my testing from fresh ISO installs indicates that it aligns with the Standard EL form.

If you find anything else, please let me know.

marknl commented 8 years ago

Hi, sorry for the delay. swamped at work. I just checked a fresh CL6 server, and it indeed seems like i was incorrect at first. The nsswitch indeed aligns with the Standard EL form.