search

trln / marc-to-argot

Tools for converting MARC records to shared TRLN ingest format
MIT License
17 stars 5 forks source link

Upgrade activesupport to v6.0.x; remove Ruby 2.4, add Ruby 2.7 to CI #272

Closed dchandekstark closed 2 years ago

dchandekstark commented 2 years ago

Looks like we need to replace normalize with unicode_normalize for activesupport 6.1+.

adjam commented 2 years ago

@dchandekstark have you tried this on Ruby 3.0 or 3.1?

If not, let me know and I can try building it with those versions.

adjam commented 2 years ago

~> 6.0.0 restricts you to activesupport 6.0.* -- I would suggest > 6.0 at this point to allow compatibility with Rails/ActiveSupport 6.1 and 7.x

dchandekstark commented 2 years ago

@adjam I have not tried Ruby 3.x.

dchandekstark commented 2 years ago

@adjam Regarding the ActiveSupport version, compatibility with v6.1 will require further changes. With Ruby 2.7 and AS 6.1 I get 411 test failures.