rajkundu
commented
2 years ago :warning: Testing
I forgot to include this important point in the original PR: I have only tested my fork on my computer. I have a 16" Intel MacBook Pro running macOS 12.5. I've compiled using Apple Clang 14.0.0. I am using VTK v9.1.0.
I would highly recommend testing on other platforms before merging this PR. Since it has only been tested on my computer, it is practically untested. I can test it on a Windows laptop next week, but if anyone else could test it (preferably on an older version of VTK), that would be greatly appreciated! Thank you!
trlsmax
Please see https://github.com/rajkundu/imgui-vtk for full details.
First of all, thank you very much for this! This repository is amazing, and I am super excited to be able to use VTK with ImGui in such an integrated way. That being said, I started by trying to fix Issue #13 and kind of got carried away. I ended up making quite a few fixes, changes, and improvements. I believe they are quite beneficial, but they carry with them some serious changes – not least because I attempted to "clean" the repository as well.
Changes
imgui_impl_vtkfiles are now deprecated in favor of usingVtkViewerobjectsdockingbranch (but doesn't depend on it; you can certainly avoid/revert this if desired)imgui,gl3w, andglfwdirectly as git submodules in this repositoryCMakeLists.txtand links them as static librariesCMakeLists-alt.txtis more similar to the oldCMakeLists.txt, building everything together from sourceVtkViewerinstances/windowsmain.cppfor details)#includestatements, etc. to match your use case.Summary
As you can see, quite a few changes have been made. For example, I opted to deprecate the
imgui_impl_vtkfiles and instead use the object-orientedVtkViewerclass. This now allows for multiple independent VTKViewer instances in a single ImGui application, which I think is quite beneficial. However, there are also many changes to style that are not strict improvements per se.Note: the "broken" IO behavior to which I am referring is that the last click outside the VTK window's bounds – e.g., clicking on another ImGui window – was transmitted to VTK. Thus, the next time you click again into the VTK window, the camera moves pseudorandomly.
So, if you're interested in only merging some changes – e.g., the IO bugfixes and using VTK's framebuffer directly instead of blitting to an internal one – please let me know! It's my fault that these changes are all a bit tangled in the commit history. Also, if you think it's best for these repos to just remain separate, then I totally understand as well!