trlsmax / imgui-vtk

test on how to integrate vtk into glfw + imgui project
MIT License
107 stars 26 forks source link

Fixes the black screen issue on macOS, fixed HiDPI rendering, add keyboard interaction #19

Open NaivelyWritten opened 1 year ago

NaivelyWritten commented 1 year ago

This PR fixes #15, added keyboard interactions, and also fixed the wrong mouse interaction under HiDPI environments such as on macOS retina screen.

rajkundu commented 6 months ago

This looks great! Unfortunately haven't had a chance to test this PR since I switched jobs a few years ago. One question: how come the math for xpos and ypos are so dissimilar? I.e., why is there no viewportSize.x term for xpos, and why is io.MousePos positive for xpos and negative for ypos, and screenPos positive for ypos and negative for xpos?

ImVec2 screenPos = ImGui::GetWindowPos();
ImVec2 viewportSize = ImGui::GetWindowSize();

auto dpiScale = ImGui::GetWindowDpiScale();
double xpos = (io.MousePos[0] - screenPos.x) * dpiScale;
double ypos = (screenPos.y + viewportSize.y - io.MousePos[1]) * dpiScale;

https://github.com/trlsmax/imgui-vtk/pull/19/commits/fa384967fdd86e45d2fd1792489c43271b1579c4#diff-86bc0a1a2a83bc219e04944ce2a5cd6f9fccecb6b1f993ac58e00453427d30f7R54-R55

ProfFan commented 6 months ago

Hi @rajkundu it's because the mouse position is in the ImGui coordinate system and the x and y poses are in the VTK coordinate system, they are defined on different corners

rajkundu commented 6 months ago

Ah, okay. The different corners makes sense for the inversion, but why is viewportSize.x not used in the xpos calculation?

ProfFan commented 6 months ago

@rajkundu because they both share the x axis, viewport size is used to convert the y:

+ (top left screen corner) - - - - - -
|
|
+ ( top left window corner)
|
|
+ (bottom left window corner)
|
+
rajkundu commented 6 months ago

Got it! Makes perfect sense, and thanks for drawing it out. I will test this when I can, likely in the next few months, but in the meantime, I'm glad that this PR is here for others to see and check out. Thanks for your contribution!