troberts-28 / react-native-timer-picker

A simple, flexible, performant duration picker for React Native apps (Expo & Bare Workflow). Great for timers, alarms and duration inputs. Includes iOS-style haptic and audio feedback.
https://www.npmjs.com/package/react-native-timer-picker
MIT License
132 stars 14 forks source link

Missing AM and PM formats #16

Closed fidaay closed 8 months ago

fidaay commented 8 months ago

Hello,

Are there any plans to implement AM and PM formats? I find out the package very complete but I feel that we really need the capability to chose between AM and PM.

troberts-28 commented 8 months ago

Hey @fidaay 👋

I didn't have immediate plants to implement this, but could definitely prioritise it as it would be pretty easy to do.

What jumped to mind for me was:

What would work best for your use case?

fidaay commented 8 months ago

Hi, thank you for your quick response, it's a good sign because it tells me that you really care. From my side, I think that the second option would be the best one as it can be perceived as more natural.

troberts-28 commented 8 months ago

Nice! I was leaning towards that one as I typed out the two options and properly thought them through.

I should be able to add this in the next couple of weeks!

troberts-28 commented 8 months ago

https://github.com/troberts-28/react-native-timer-picker/assets/72606459/c6381ca3-7818-4775-b5d3-c50ce5d85ac0

Progress so far! âš¡

troberts-28 commented 8 months ago

@fidaay just pushed this feature in v1.4.0 - try it out and let me know what you think!