search

troberts-28 / react-native-timer-picker

A simple, flexible, performant duration picker for React Native apps (Expo & Bare Workflow). Great for timers, alarms and duration inputs. Includes iOS-style haptic and audio feedback.
https://www.npmjs.com/package/react-native-timer-picker
MIT License
143 stars 19 forks source link

fix: actually enable FlatList props to be passed down to TimerPicker #30

Closed giovanniRodighiero closed 4 months ago

giovanniRodighiero commented 5 months ago

Ops, my bad. 😅

I put the FlatList prop in the destructuring, but then I forgot to passed it down explicitly, so it wasn't working. I removed the declaration so it ends up inside otherProps.

I didn't spot it because I was working with a copy of the source code in my main project and then I replicated the changes on the original repo 🤦

I added a simple test to make up for it 😁

troberts-28 commented 4 months ago

Ah no worries, easily done! Should've spotted that when I reviewed it.

And thank you for adding the test 👏

troberts-28 commented 4 months ago

Have released the fix in v1.9.1