Finish called on destroy instead of cancel

troch / angular-multi-step-form

An angular module for creating multi step forms / wizards

http://troch.github.io/angular-multi-step-form

ISC License

144 stars 44 forks source link

Finish called on destroy instead of cancel #41

Closed rdzidziguri closed 8 years ago

rdzidziguri commented 8 years ago

I have a multystep container within another directive which works perfectly till i try to destroy parent container. when parent container is destroyed, instead of calling cancel it calls onFinish which makes it usless because every time i try to close drawer onFinish is called which results in API call. is that normal should not finish be called explicitly? why is it always calling finish even if parent container gets destroyed without finishing wizard?

troch commented 8 years ago

No it's not normal, and that is a bug, fixed in 1.2.9