search

troch / angular-multi-step-form

An angular module for creating multi step forms / wizards
http://troch.github.io/angular-multi-step-form
ISC License
144 stars 44 forks source link

step is passed to the onStepChange method as an argument #50

Open rdzidziguri opened 8 years ago

troch commented 8 years ago

Thanks for your contribution. This seems perfectly reasonable to add this feature and I'll merge it and release it as soon as I'm finished with what I'm doing (working on another new feature and updating dependencies + build). Should be done by the end of the week.

rdzidziguri commented 8 years ago

The only question i have regarding this is will step include index or current page? the problem i cam up with this solution was to know which is active step in callback method.

U are welcome i am always glad to contribute to the good OpenSource projects like this.

rdzidziguri commented 8 years ago

Do we have any update on this?

rdzidziguri commented 8 years ago

Do we have any status update on this or when we are going to receive new release?

troch commented 8 years ago

I'm hoping to have an update soon, I've been unable to free some time due to work and family commitments.

troch commented 8 years ago

The method will pass the active step index, is that fine? Or would prefer it to pass the step object instead?

rdzidziguri commented 8 years ago

does step include index as its own property? if yest we could pass that object otherwise i do not see reason for this so index would be fine, but again if step instance will include index itself this is best i think/

troch commented 8 years ago

Nope steps don't include an index as its own property. I think I need to first change how indexing works (they are not zero based, that was a stupid decision) before exposing indexes.

rdzidziguri commented 8 years ago

Actually after adding controller for step container i thin it is extra to re implement indexing anyone could easily get active step index and using base methods get step info.

troch commented 8 years ago

OK. I might merge it at some point. I'll rework indexing to be zero based in a near future (breaking change, will bump version to 2.0.0).