search

troch / route-node

A package to create a tree of named routes
MIT License
20 stars 15 forks source link

fullName in callback is inconsistent? #27

Open c-dante opened 4 years ago

c-dante commented 4 years ago

Not sure what the intention is here: https://github.com/troch/route-node/blob/71fd8d9053c223ef9e7e699df2ab677852280332/modules/RouteNode.ts#L142-L161

But in the cb, the name field is overwritten by this fullName property.

This is the only time in the entire lifecycle of the RouteNode where the name is obscured and overwritten as such.

Is this intentional? It's breaking code in router5 (and probably other places?) that rely on the callback.

It seems extra bad that the node itself doesn't get this fullName property -- just the spread in this callback.