trodi / electron-splashscreen

Simple splashscreen for electron applications.
MIT License
170 stars 29 forks source link

npm Images not loading #13

Closed trodi closed 5 years ago

trodi commented 6 years ago

readme's images aren't loading on the npm page. It appears that npm isn't converting my relative img paths to their github equivalent. It use to do this just fine for my demo.gif. In my research, relative paths have worked for some repos, but I'm not sure why/when they do. However, it appears that svg images never work unless you add ?sanitize=true to the link. I also didn't want to publish my images as part of the package to reduce the size when a user npm i.

After failing to get the relative links to work, I've done the following:

Ideally, I could specify, for npm, files that are part of the package but not downloaded when installed (e.g., docs and readme images), then I could keep my relative paths and npm would be completely in charge of serving up a package's content rather than using github links.

trodi commented 5 years ago

Addressed in v0.3.4.