Avoid bulk download crashing because of encode errors

troeger / opensubmit

Just another submission system for course assignment solutions. Supports semi-automated code evaluation.

GNU Affero General Public License v3.0

30 stars 18 forks source link

Avoid bulk download crashing because of encode errors #244

Closed johenning closed 6 years ago

johenning commented 6 years ago

Assignment with UTF8/16 encodings failed to bulk download because of encoding errors when decompressing. Quick solution: Copy Zip instead of unpacking

coveralls commented 6 years ago

Coverage decreased (-0.06%) to 81.001% when pulling 4de541b08dcc09a00a6f8a27ca8bb752730759d5 on johenning:encoding_error into 1b53ac8e8b6df035389302307b817c795d399d8a on troeger:master.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 80.943% when pulling 725a7f15cdc58722c50e6ec8b8b31616ee36b671 on johenning:encoding_error into 1b53ac8e8b6df035389302307b817c795d399d8a on troeger:master.

johenning commented 6 years ago

Similar problems could occur when downloading/previewing deflate64 encoded zip files. Fixed in 2b0aac8 and 159b1be respectively.

troeger commented 6 years ago

Very nice, thanks.