search

troelsbjerre / Bottleneck

Factorio mod that tell you which assemblers are starved of ingredients
Other
29 stars 21 forks source link

Some issues with compatability with NPE #47

Closed wheybags closed 5 years ago

wheybags commented 5 years ago

Hi, just wanted to let you know that some users are reporting errors when running the new "Introduction" scenario while they have your mod installed. Here's the bug reports on our forums, moved to "not a bug" because I believe the issue is on your side.

https://forums.factorio.com/viewtopic.php?f=226&t=65305 https://forums.factorio.com/viewtopic.php?f=226&t=65307

troelsbjerre commented 5 years ago

Yes, it's an issue on our side. I'm guessing the floating lights are due to some scripted entities in the scenario that we just treat as normal entities. I have no clue what causes the crash bug. However, the mod is due for an overhaul with the nice 0.17 api, so the bugs might go away in the overhaul. It will be a few days before I can find the time for this :(

Nexela commented 5 years ago

Reminder to self to publish the pr with some examples. !

On Thu, Feb 28, 2019, 2:18 PM troelsbjerre notifications@github.com wrote:

Yes, it's an issue on our side. I'm guessing the floating lights are due to some scripted entities in the scenario that we just treat as normal entities. I have no clue what causes the crash bug. However, the mod is due for an overhaul with the nice 0.17 api, so the bugs might go away in the overhaul. It will be a few days before I can find the time for this :(

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/troelsbjerre/Bottleneck/issues/47#issuecomment-468401357, or mute the thread https://github.com/notifications/unsubscribe-auth/ANUy4B1WdkdrgxJQHjUi6TGpmIvYLnKwks5vSCuDgaJpZM4bXgGh .

wheybags commented 5 years ago

So, I think what's happening is that we use the new clone_area method, and it's cloning your icon entities. You should be able to use on_area_cloned somehow to prevent this.

troelsbjerre commented 5 years ago

I've added a check on_entity_cloned that checks whether it's a bottleneck-signal, and if so, destroys it. I am not sure it's the right way, but it appears to have fixed the NPE issue described above. Fixed in v0.10.2