troelsbjerre / Bottleneck

Factorio mod that tell you which assemblers are starved of ingredients
Other
29 stars 21 forks source link

Compensate for new electric drill graphics having status light built in. #79

Closed troelsbjerre closed 3 years ago

troelsbjerre commented 4 years ago

https://www.reddit.com/r/factorio/comments/h0efru/til_the_new_miner_model_has_status_lights/

Should the Bottleneck signals be removed from electric mining drills, or are there states that still require separate signalling?

lstor commented 4 years ago

I can't think of any states that require separate signalling. The built-in status lights have states for active, blocked and ore patch empty. In addition, the status light is turned off when there's no power.

image

itpropro commented 4 years ago

Thanks a lot for your work on this mod. It would be great to at least add an option for this indicator, as the built-in light is very hard to see for color blind people. There is also a discussion going on here https://mods.factorio.com/mod/Bottleneck/discussion/5efd3a25acf8d214148f66d7 about why people want to have the indicator back.

troelsbjerre commented 4 years ago

Yeah, it seems like removing the indicator was not universally popular, to say the least. I will reopen the issue, as there needs to be an option for selecting which types of machines should have a light or not. Unfortunately, I haven't had the time to do this properly yet; according to my steam profile, I have only had time for a combined 4 hours of games over the past three months :(

Cisien commented 4 years ago

I personally find it difficult to see what the state of the drills are, and i'm not colorblind. The colors on the stock model very easily blend into the background noise of the game

troelsbjerre commented 4 years ago

I agree that it was a mistake to disable this light in general. There needs to be a more fine grained control for enabling and disabling for each individual type of machine, which isn't a quick fix. I haven't had time for anything factorio related for several month, so the work around for the time being is just to install the previous version of the mod, which is available on the mod portal.

lethargi commented 4 years ago

I tried reverting the changes by lstor manually. it didnt work. But if I install the previous version ( 0.11.3), it works. Can someone explain why this?

My steps:

  1. unzip 0.11.4 mod files into my mod folder
  2. modify the control.lua file to remove this line
  3. restart Factorio
  4. check if electric miners have signal -> they dont
  5. Retry by donwloading and installing 0.11.3 -> signals show up

Update Seems just removing that line does not work; for some reason, i actually have to modify the version number in info.json to 0.11.3 and rename the mod folder to indicate this. Strange.

troelsbjerre commented 4 years ago

The issue is that you need to trigger a full recomputation, which only happens automatically when the version number changes.

troelsbjerre commented 4 years ago

I finally had some time to play, and I rolled back the change that disabled the lights on the mining drills. It is not really a satisfying solution, as the mod should allow the player much more fine grained control over which entities have lights.