search

troelskn / laravel-fillable-relations

Provides HasFillableRelations trait to Eloquent models
64 stars 23 forks source link

Can this package use versioning? #3

Closed montyclt closed 7 years ago

montyclt commented 7 years ago

Can this package use majors versions compatible with different versions of Laravel?

I mean, use branch with major versions of package thats doesn't broke public API and doesn't stop being compatible with different Laravel versions.

An example can be:

I have a project with Laravel 5.4 (currently will not be upgraded) and with last commit I lose compatibility.

Thanks you 😘 !

troelskn commented 7 years ago

Yes, we need to figure that out. I initially wrote the code against 5.3, but I bumped the version to 5.5, since the test passed. What issues are you seeing with 5.4?

montyclt commented 7 years ago

With last commit, the package require illumitate/database ^5.5, but Laravel 5.4 replace ^5.4 version of illumitate/database. I have conflicts in composer.

troelskn commented 7 years ago

OK. I suppose we should keep it at ^5.3, since it works with that version. It would still be nice to have circle-ci build against latest version, but that will have to wait. I've downgraded the requirements back to 5.3 now.