Handle or fail tests when smell detectors return nil

troessner / reek

Code smell detector for Ruby

https://github.com/troessner/reek

MIT License

4.05k stars 280 forks source link

Handle or fail tests when smell detectors return nil #1027

Closed mvz closed 8 years ago

mvz commented 8 years ago

When #sniff returns nil instead of [], our tests still pass but we output our please-report-an-exception text. We should either allow nil output or fail tests in this case.

I found this with mutant when implementing #1026.

troessner commented 8 years ago

We should either allow nil output or fail tests in this case.

👍 for the latter - I think this should fail our tests.

mvz commented 8 years ago

If no-one has any other input, I'll have a go at implementing this.

troessner commented 8 years ago

👍

backus commented 8 years ago

Big :thumbsup: for this. Having failing tests not look like normal RSpec failures was quite confusing when I was making my first contribution