search

troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4.04k stars 279 forks source link

Cucumber tests not run by `bundle exec rake`? #1198

Closed IanWhitney closed 7 years ago

IanWhitney commented 7 years ago

Looking at the Readme

https://github.com/troessner/reek#developing-reek--contributing

I thought Cucumber tests would run with bundle exec rake

But after setting up a Cucumber test that I knew would fail, bundle exec rake continued to tell me that all my tests were green.

Running bundle exec cucumber ran the features and showed me my failing test as expected.

troessner commented 7 years ago

Good catch! Just pushed a fix for this.

mvz commented 7 years ago

This seems wrong; I'll look into it more this weekend.

troessner commented 7 years ago

Pretty sure that was intentional back then since our cucumber features are slower than a snail on opium :-/

mvz commented 7 years ago

I just checked, and when I run bundle exec rake, both RSpec and Cucumber tests are run. Something else must be going on here. @IanWhitney does your scenario show up when you run bundle exec cucumber features --format progress --color (this is what the rake task does)?

mvz commented 7 years ago

slower than a snail on opium

Thank you for this brilliant simile!

mvz commented 7 years ago

@IanWhitney can you give us some more info on this please? Is your scenario run when you do bundle exec rake ci? What is the name of your scenario file?

IanWhitney commented 7 years ago

This can be closed. Thanks.

IanWhitney commented 7 years ago

I must have been typing the wrong command or something. Not sure what was going on here. But from what I see now bundle exec rake does run the Cucumber tests as expected. Sorry for the confusion.

mvz commented 7 years ago

Thanks for the clarification, @IanWhitney.