Fix ModuleInitialize false positive with custom Data constructor

[bkuhlmann]

Overview

Hello. :wave: I'm working on upgrading to Ruby 3.2.0 by leveraging the new Data primitive and discovered a slight bug where Reek doesn't handle a custom Data constructor.

Screenshots

Steps to Recreate

• Install Ruby 3.2.0 RC1.
  • If you need a Docker image for quick experimentation, I have one built using Ruby 3.2.0 RC1. You'd just need to use the latest image. Otherwise, installing Ruby via your favorite Ruby version manager will work too.
• Save the code snippet (provided below) as test.rb and run as reek test.rb to reproduce.
  Example Code Snippet

# frozen_string_literal: true

RootMail = Data.define :from, :to do
  # ✅ Reek doesn't detect this as a code smell.
  def initialize from: nil, to: nil
    super
  end
end

module Demo
  Mail = Data.define :from, :to do
    # ❌ Reek thinks this is a code smell.
    def initialize from: nil, to: nil
      super
    end
  end
end

Workaround

As a workaround, I can configure Reek to ignore the source files with false positives but would definitely prefer not to have to do that. 😅

Environment

• Ruby: ruby 3.2.0rc1 (2022-12-18) [arm64-darwin22.2.0]
• Reek: 6.1.2

[mvz]

Thanks, @bkuhlmann, I'll take a look.

[bkuhlmann]

Hey. :wave: Wanted to touch base on this. Would this be possible to support? I run into this a lot when working Data primitives and would make using them more enjoyable when this isn't flagged.

[mvz]

Hi @bkuhlmann thanks for the ping. I've created a pull request for this.