Closed bkuhlmann closed 4 weeks ago
Thanks, @bkuhlmann. We probably missed this because RuboCop is part of the bundle in development.
I found this independently on our project the other day but had forgotten to come here and report it. π
Worked fine after adding rexml to our Gemfile, so that seems to be the only missing dependency.
Hey @mvz this dependency was added: https://github.com/troessner/reek/pull/1703/files But it does not seem like it is included in the 6.1.4 release: https://github.com/troessner/reek/blob/v6.1.4/reek.gemspec We should probably release a new minor version with rexml included.
Also, we did not add anything about it to the CHANGELOG. So I wonder if we should add a note about it to the CHANGELOG.
In the mean time, Reek 6.2.0 has been released which includes the rexml dependency in the gemspec.
Thanks! Actually, you mean Reek 6.3.0 but understand what you mean. :wink:
No I meant 6.2.0 because it already includes the change :smile:
Oh, sorry, I should have double checked. I thought this functionality rolled out in 6.3.0 but it was 6.2.0. I stand corrected! π
Overview
Hello. π I stumbled across an issue where I can't include Reek as a gem unless RuboCop is also required. I can see that
Reek::Report::XMLReport
requiresrexml/document
but there appears to be an order of operation issue where REXML isn't loaded in time.Steps to Recreate
You can run the following script to reproduce:
Upon running
./snippet
, I'll get the following output:Stack Dump
``` Fetching gem metadata from https://rubygems.org/........ Resolving dependencies... Using ast 2.4.2 Using bundler 2.4.6 Using kwalify 0.7.2 Using rainbow 3.1.1 Using parser 3.2.0.0 Using reek 6.1.4Environment