search

troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4k stars 279 forks source link

Add missing dependency rexml #1703

Closed tricknotes closed 1 year ago

tricknotes commented 1 year ago

rexml has been removed from default gems since Ruby 3.0. https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/

To use rexml, it should be added as runtime dependency. https://github.com/troessner/reek/blob/v6.1.4/lib/reek/report/xml_report.rb#L13

Since rexml is depended from rubocop and kramdown that are only development dependencies, all tests are passed on CI.

mvz commented 1 year ago

Thanks @tricknotes! Can you please add a version limitation for this? I think "~> 3.1" should be fine.

tricknotes commented 1 year ago

@mvz Thanks. It is a good idea. I updated this PR with version limitation.