search

troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4k stars 279 forks source link

Update rubocop requirement from ~> 1.49.0 to ~> 1.50.0 #1713

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.50

New features

  • #11749: Add new Lint/DuplicateMatchPattern cop. (@​koic)
  • #11773: Make Layout/ClassStructure aware of singleton class. (@​koic)
  • #11779: Make Lint/RedundantStringCoercion aware of print method arguments. (@​koic)
  • #11776: Make Metrics/ClassLength aware of singleton class. (@​koic)
  • #11775: Make Style/TrailingBodyOnClass aware of singleton class. (@​koic)

Bug fixes

  • #11758: Fix a false positive for Style/RedundantLineContinuation when line continuations for string. (@​koic)
  • #11754: Fix a false positive for Style/RedundantLineContinuation when using && and || with a multiline condition. (@​ydah)
  • #11765: Fix an error for Style/MultilineMethodSignature when line break after def keyword. (@​koic)
  • #11762: Fix an incorrect autocorrect for Style/ClassEqualityComparison when comparing a variable or return value for equality. (@​koic)
  • #11752: Fix a false positive for Style/RedundantLineContinuation when using line concatenation and calling a method without parentheses. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.50.0 (2023-04-11)

New features

  • #11749: Add new Lint/DuplicateMatchPattern cop. ([@​koic][])
  • #11773: Make Layout/ClassStructure aware of singleton class. ([@​koic][])
  • #11779: Make Lint/RedundantStringCoercion aware of print method arguments. ([@​koic][])
  • #11776: Make Metrics/ClassLength aware of singleton class. ([@​koic][])
  • #11775: Make Style/TrailingBodyOnClass aware of singleton class. ([@​koic][])

Bug fixes

  • #11758: Fix a false positive for Style/RedundantLineContinuation when line continuations for string. ([@​koic][])
  • #11754: Fix a false positive for Style/RedundantLineContinuation when using && and || with a multiline condition. ([@​ydah][])
  • #11765: Fix an error for Style/MultilineMethodSignature when line break after def keyword. ([@​koic][])
  • #11762: Fix an incorrect autocorrect for Style/ClassEqualityComparison when comparing a variable or return value for equality. ([@​koic][])
  • #11752: Fix a false positive for Style/RedundantLineContinuation when using line concatenation and calling a method without parentheses. ([@​koic][])

1.49.0 (2023-04-03)

New features

  • #11122: Add new Style/RedundantLineContinuation cop. ([@​ydah][])
  • #11696: Add new Style/DataInheritance cop. ([@​ktopolski][])
  • #11746: Make Layout/EndAlignment aware of pattern matching. ([@​koic][])
  • #11750: Make Metrics/BlockNesting aware of numbered parameter. ([@​koic][])
  • #11699: Make Style/ClassEqualityComparison aware of Class#to_s and Class#inspect for class equality comparison. ([@​koic][])
  • #11737: Make Style/MapToHash and Style/MapToSet aware of numbered parameters. ([@​koic][])
  • #11732: Make Style/MapToHash and Style/MapToSet aware of symbol proc. ([@​koic][])
  • #11703: Make Naming/InclusiveLanguage support autocorrection when there is only one suggestion. ([@​koic][])

Bug fixes

  • #11730: Fix an error for Layout/HashAlignment when using anonymous keyword rest arguments. ([@​koic][])
  • #11704: Fix a false positive for Lint/UselessMethodDefinition when method definition with non access modifier containing only super call. ([@​koic][])
  • #11723: Fix a false positive for Style/IfUnlessModifier when using one-line pattern matching as a if condition. ([@​koic][])
  • #11725: Fix an error when insufficient permissions to server cache dir are granted. ([@​koic][])
  • #11715: Ensure default configuration loads. ([@​koic][])
  • #11742: Fix error handling in bundler standalone mode. ([@​composerinteralia][])
  • #11712: Fix a crash in Lint/EmptyConditionalBody. ([@​gsamokovarov][])
  • #11641: Fix a false negative for Layout/ExtraSpacing when there are many comments with extra spaces. ([@​nobuyo][])
  • #11740: Fix a false positive for Lint/NestedMethodDefinition when nested definition inside *_eval and *_exec method call with a numblock. ([@​ydah][])
  • #11685: Fix incorrect directive comment insertion when percent array violates Layout/LineLength cop. ([@​nobuyo][])
  • #11706: Fix infinite loop when --disable-uncorrectable option and there is a multi-line percent array violates Layout/LineLength. ([@​nobuyo][])
  • #11697: Fix Lint/Syntax behavior when --only is not given the cop name. ([@​koic][])
  • #11709: Fix value omission false positive in Style/MethodCallWithArgsParentheses. ([@​gsamokovarov][])

Changes

  • #11739: Make Style/RedundantParentheses aware of redundant method argument parentheses. ([@​koic][])

... (truncated)

Commits
  • b71808e Cut 1.50
  • fbf9949 Update Changelog
  • d2bbe3a Make Lint/RedundantStringCoercion aware of print method arguments
  • b0e6591 Add specs for redundant SafeAutoCorrect: true and AutoCorrect: true
  • 27b7ceb Use RuboCop 1.17.1+
  • f060379 Use RuboCop Performance 1.17
  • a03573c Make Metrics/ClassLength aware of singleton class
  • 78d5dd5 Merge pull request #11775 from koic/make_style_trailing_body_on_class_aware_o...
  • 2c1f115 Make Style/TrailingBodyOnClass aware of singleton class
  • f1a7b6a Make Style/ClassStructure aware of singleton class
  • Additional commits viewable in compare view


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mvz commented 1 year ago

The linting failure is a false positive that has already been fixed in https://github.com/rubocop/rubocop/pull/11784. Let's wait for the next bugfix release.

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.