search

troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4k stars 279 forks source link

Update rubocop requirement from ~> 1.52.0 to ~> 1.53.0 #1721

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.53

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. (@​koic)
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. (@​koic)
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. (@​koic)
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. (@​koic)
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. (@​koic)
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. (@​koic)
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. (@​koic)
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. (@​koic)
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. (@​koic)
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. (@​koic)
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. (@​ydah)
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. (@​rwstauner)

Changes

Changelog

Sourced from rubocop's changelog.

1.53.0 (2023-06-23)

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. ([@​koic][])
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. ([@​koic][])
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. ([@​koic][])
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. ([@​koic][])
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. ([@​koic][])
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. ([@​koic][])
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. ([@​koic][])
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. ([@​koic][])
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. ([@​koic][])
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. ([@​koic][])
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. ([@​ydah][])
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. ([@​rwstauner][])

Changes

1.52.1 (2023-06-12)

Bug fixes

  • #11944: Fix an incorrect autocorrect for Style/SoleNestedConditional with Style/MethodCallWithArgsParentheses. ([@​koic][])
  • #11930: Fix exception on Lint/InheritException when class definition has non-constant siblings. ([@​rafaelfranca][])
  • #11919: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for. ([@​koic][])
  • #11928: Fix an incorrect autocorrect for Lint/AmbiguousBlockAssociation. ([@​koic][])
  • #11915: Fix a false positive for Lint/RedundantSafeNavigation when &. is used for to_s, to_i, to_d, and other coercion methods. ([@​lucthev][])

Changes

1.52.0 (2023-06-02)

New features

... (truncated)

Commits
  • 80485d2 Cut 1.53
  • f6bac40 Update Changelog
  • f23bd40 [Fix #11972] Fix an error for Lint/Void
  • 04ea207 Fix a false positive for Lint/RedundantRequireStatement
  • 273f9bd Revert "Change include paths to be relative to working directory rather than ...
  • 1ed69f8 Add new Style/ReturnNilInPredicateMethodDefinition cop
  • 0c5c4fc Remove a useless style guide URL
  • 766e208 Mark Layout/ClassStructure as unsafe to autocorrect
  • 1e2d84a Merge pull request #11940 from iMacTia/fix/lint-missing-super-configurable-st...
  • 09d0ff5 [Fix #8506] Add AllowedParentClasses config to Lint/MissingSuper.
  • Additional commits viewable in compare view


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 1 year ago

A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.