troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4k stars 279 forks source link

Fix cucumber_opts warning #1736

Closed JuanVqz closed 8 months ago

JuanVqz commented 8 months ago

I was reading the Developing Reek Contributing to understand how reek works, then run the rake console and saw the warning message.

➜  reek git:(master) be rake console
WARNING: consider using an array rather than a space-delimited string with cucumber_opts to avoid undesired behavior.

after making it an array the warning was gone, let's see if that works for you.

troessner commented 8 months ago

Thanks for this, just checked it on my machine, seems to do the trick! If you rebase against master the rubocop failure will go away and we can merge this one ;)

JuanVqz commented 8 months ago

@troessner rebased!

mvz commented 8 months ago

Thanks, @JuanVqz!