troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4k stars 279 forks source link

Fix Instance Variable Assumption false positive #1737

Closed JuanVqz closed 8 months ago

JuanVqz commented 8 months ago

Can you please have a look?

I hope this fixes #1492

What this basically does is look up through all the initializers if it matches the ivasgn to consider it instance variable assumption.

troessner commented 8 months ago

Hey @JuanVqz ,

that does look nice! @mvz any comments?

JuanVqz commented 8 months ago

@troessner and @mvz thank you for having a look, I rebased it :+1:

mvz commented 8 months ago

Thanks @JuanVqz!