search

troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4k stars 279 forks source link

ISSUE-1734 Add missing configuration warning #1741

Open fbuys opened 8 months ago

fbuys commented 8 months ago

This PR adds a more descriptive error message when users add a detector without configuration. Before this change a NoMethodError exception was raised with an unclear error message. Now we catch this exception and provide a more helpful error message.

A better future option might be add dry-schema. The current yaml schema validator is outdated and does not seem to have good documentation.

See: https://github.com/troessner/reek/issues/1734

mvz commented 8 months ago

An alternative solution would be to move to dry-schema immediately.

troessner commented 8 months ago

Agree with all of @mvz comments so far :)

fbuys commented 7 months ago

Making this a WIP PR, waiting on https://github.com/troessner/reek/pull/1749