search

troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4k stars 279 forks source link

Update rubocop requirement from ~> 1.59.0 to ~> 1.60.0 #1763

Closed dependabot[bot] closed 5 months ago

dependabot[bot] commented 5 months ago

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.60

Bug fixes

  • #12603: Fix an infinite loop error for Style/MultilineTernaryOperator when using a method call as a ternary operator condition with a line break between receiver and method. (@​koic)
  • #12549: Fix a false positive for Style/RedundantLineContinuation when line continuations for multiline leading dot method chain with a blank line. (@​koic)
  • #12610: Accept parentheses in argument calls with blocks for Style/MethodCallWithArgsParentheses omit_parentheses style. (@​gsamokovarov)
  • #12580: Fix an infinite loop error for Layout/EndAlignment when misaligned in singleton class assignments with EnforcedStyleAlignWith: variable. (@​koic)
  • #12548: Fix an infinite loop error for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArrayAlignment. (@​koic)
  • #12236: Fix an error for Lint/ShadowedArgument when self assigning to a block argument in for. (@​koic)
  • #12569: Fix an error for Style/IdenticalConditionalBranches when using if...else with identical leading lines that assign to self.foo. (@​koic)
  • #12437: Fix an infinite loop error for EnforcedStyle: omit_parentheses of Style/MethodCallWithArgsParentheses with Style/SuperWithArgsParentheses. (@​koic)
  • #12558: Fix an incorrect autocorrect for Style/MapToHash when using map.to_h without receiver. (@​koic)
  • #12179: Let --auto-gen-config generate Exclude when Max is overridden. (@​jonas054)
  • #12574: Fix bug for unrecognized style in --auto-gen-config. (@​jonas054)
  • #12542: Fix false positive for Lint/MixedRegexpCaptureTypes when using look-ahead matcher. (@​marocchino)
  • #12607: Fix a false positive for Style/RedundantParentheses when regexp literal attempts to match against a parenthesized condition. (@​koic)
  • #12539: Fix false positives for Lint/LiteralAssignmentInCondition when a collection literal contains non-literal elements. (@​koic)
  • #12571: Fix false positives for Naming/BlockForwarding when using explicit block forwarding in block method. (@​koic)
  • #12537: Fix false positives for Style/RedundantParentheses when AllowInMultilineConditions: true of Style/ParenthesesAroundCondition. (@​koic)
  • #12578: Fix false positives for Style/ArgumentsForwarding when rest arguments forwarding to a method in block. (@​koic)
  • #12540: Fix false positives for Style/HashEachMethods when rest block argument of Enumerable#each method is used. (@​koic)
  • #12529: Fix false positives for Style/ParenthesesAroundCondition. (@​koic)
  • #12556: Fix false positives for Style/RedundantParentheses when parentheses are used around a semantic operator in expressions within assignments. (@​koic)
  • #12541: Fix false negative in Style/ArgumentsForwarding when a block is forwarded but other args aren't. (@​dvandersluis)
  • #12581: Handle trailing line continuation in Layout/LineContinuationLeadingSpace. (@​eugeneius)
  • #12601: Make Style/EachForSimpleLoop accept block with no parameters. (@​koic)

Changes

  • #12535: Allow --autocorrect with --display-only-fail-level-offenses. (@​naveg)
  • #12572: Follow a Ruby 3.3 warning for Security/Open when open with a literal string starting with a pipe. (@​koic)
  • #12453: Make Style/RedundantEach aware of safe navigation operator. (@​koic)
  • #12233: Make Style/SlicingWithRange aware of redundant and beginless range. (@​koic)
  • #12388: Reject additional 'expanded' EnforcedStyle options when --no-auto-gen-enforced-style is given. (@​kpost)
  • #12593: Require Parser 3.3.0.2 or higher. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.60.0 (2024-01-15)

Bug fixes

  • #12603: Fix an infinite loop error for Style/MultilineTernaryOperator when using a method call as a ternary operator condition with a line break between receiver and method. ([@​koic][])
  • #12549: Fix a false positive for Style/RedundantLineContinuation when line continuations for multiline leading dot method chain with a blank line. ([@​koic][])
  • #12610: Accept parentheses in argument calls with blocks for Style/MethodCallWithArgsParentheses omit_parentheses style. ([@​gsamokovarov][])
  • #12580: Fix an infinite loop error for Layout/EndAlignment when misaligned in singleton class assignments with EnforcedStyleAlignWith: variable. ([@​koic][])
  • #12548: Fix an infinite loop error for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArrayAlignment. ([@​koic][])
  • #12236: Fix an error for Lint/ShadowedArgument when self assigning to a block argument in for. ([@​koic][])
  • #12569: Fix an error for Style/IdenticalConditionalBranches when using if...else with identical leading lines that assign to self.foo. ([@​koic][])
  • #12437: Fix an infinite loop error for EnforcedStyle: omit_parentheses of Style/MethodCallWithArgsParentheses with Style/SuperWithArgsParentheses. ([@​koic][])
  • #12558: Fix an incorrect autocorrect for Style/MapToHash when using map.to_h without receiver. ([@​koic][])
  • #12179: Let --auto-gen-config generate Exclude when Max is overridden. ([@​jonas054][])
  • #12574: Fix bug for unrecognized style in --auto-gen-config. ([@​jonas054][])
  • #12542: Fix false positive for Lint/MixedRegexpCaptureTypes when using look-ahead matcher. ([@​marocchino][])
  • #12607: Fix a false positive for Style/RedundantParentheses when regexp literal attempts to match against a parenthesized condition. ([@​koic][])
  • #12539: Fix false positives for Lint/LiteralAssignmentInCondition when a collection literal contains non-literal elements. ([@​koic][])
  • #12571: Fix false positives for Naming/BlockForwarding when using explicit block forwarding in block method. ([@​koic][])
  • #12537: Fix false positives for Style/RedundantParentheses when AllowInMultilineConditions: true of Style/ParenthesesAroundCondition. ([@​koic][])
  • #12578: Fix false positives for Style/ArgumentsForwarding when rest arguments forwarding to a method in block. ([@​koic][])
  • #12540: Fix false positives for Style/HashEachMethods when rest block argument of Enumerable#each method is used. ([@​koic][])
  • #12529: Fix false positives for Style/ParenthesesAroundCondition. ([@​koic][])
  • #12556: Fix false positives for Style/RedundantParentheses when parentheses are used around a semantic operator in expressions within assignments. ([@​koic][])
  • #12541: Fix false negative in Style/ArgumentsForwarding when a block is forwarded but other args aren't. ([@​dvandersluis][])
  • #12581: Handle trailing line continuation in Layout/LineContinuationLeadingSpace. ([@​eugeneius][])
  • #12601: Make Style/EachForSimpleLoop accept block with no parameters. ([@​koic][])

Changes

  • #12535: Allow --autocorrect with --display-only-fail-level-offenses. ([@​naveg][])
  • #12572: Follow a Ruby 3.3 warning for Security/Open when open with a literal string starting with a pipe. ([@​koic][])
  • #12453: Make Style/RedundantEach aware of safe navigation operator. ([@​koic][])
  • #12233: Make Style/SlicingWithRange aware of redundant and beginless range. ([@​koic][])
  • #12388: Reject additional 'expanded' EnforcedStyle options when --no-auto-gen-enforced-style is given. ([@​kpost][])
  • #12593: Require Parser 3.3.0.2 or higher. ([@​koic][])

1.59.0 (2023-12-11)

New features

Bug fixes

  • #12434: Fix a false positive for Lint/LiteralAssignmentInCondition when using interpolated string or xstring literals. ([@​koic][])
  • #12435: Fix a false positive for Lint/SelfAssignment when using attribute assignment with method call with arguments. ([@​koic][])
  • #12444: Fix false positive for Style/HashEachMethods when receiver literal is not a hash literal. ([@​koic][])
  • #12524: Fix a false positive for Style/MethodCallWithArgsParentheses when EnforcedStyle: omit_parentheses and parens in when clause is used to pass an argument. ([@​koic][])
  • #12505: Fix a false positive for Style/RedundantParentheses when using parenthesized lambda or proc with do...end block. ([@​koic][])

... (truncated)

Commits
  • 56e88bb Cut 1.60
  • 84ee480 Update Changelog
  • 6a83571 Remove useless require fileutils
  • d58940b Rename git_hub to github
  • 6d829af Add style guide link for Style/SlicingWithRange
  • 172937e Add style guide link for Style/OptionHash
  • c51dfec Add start of string to regexps in DisabledConfigFormatter
  • 4e392b2 Include expanded EnforcedStyle options when --no-auto-gen-enforced-style is g...
  • b36fe4a [Fix #12601] Make Style/EachForSimpleLoop accept block with no parameters
  • 075d4d5 [Fix #12542] Fix false positive for Lint/MixedRegexpCaptureTypes
  • Additional commits viewable in compare view


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mvz commented 5 months ago

I'm confused by these new offenses ...

bkuhlmann commented 5 months ago

The offenses you are referring to are related to this Ruby Issue that is scheduled for release in Ruby 3.3.1. It's unfortunate but what I've done is added RuboCop TODOs (in my code, at least) in order to keep the build green so they can be removed after Ruby 3.3.1 drops if that helps. You might want to do the same for these offenses.

mvz commented 5 months ago

@bkuhlmann That may be related, but when targeting Ruby 3.0 I don't expect autocorrection to anonymous block forwarding either. Anyway, I opened an issue here: https://github.com/rubocop/rubocop/issues/12618

dependabot[bot] commented 5 months ago

Superseded by #1764.