General idea list for reek

troessner / reek

Code smell detector for Ruby

https://github.com/troessner/reek

MIT License

4.05k stars 280 forks source link

General idea list for reek #556

Closed troessner closed 8 years ago

troessner commented 9 years ago

[ ] Fix all known bugs
[ ] New smell detectors (All of those are still up for discussion):
- Detect more type checking
- Inappropriate intimacy: a class that has dependencies on implementation details of another class.
- Refused bequest: a class that overrides a method of a base class in such a way that the contract of the base class is not honored by the derived class. See Liskov substitution principle.
- Lazy class / Freeloader: a class that does too little.
- LoD violations
- Code Calisthenics
- IVar assumptions
- Uninitialized IVar
- Magic number / string
- ExcessiveConstantUsage

mvz commented 9 years ago

Maybe we can open discussion issues on each of those smells? We already have a Rails Mode ticket, by the way.

troessner commented 9 years ago

Maybe we can open discussion issues on each of those smells?

Absolutely! However I'd just would do that when we actually want to discuss them, not prematurely.

jdickey commented 9 years ago

What specifically did you have in mind by "Code Calisthenics"? I've seen very little use of that phrase, and most of what I have seen has been very PHP-focussed. Care to elaborate?

troessner commented 9 years ago

What specifically did you have in mind by "Code Calisthenics"? I've seen very little use of that phrase, and most of what I have seen has been very PHP-focussed. Care to elaborate?

Yes, that statement doesnt make much sense without going into details. I created a separate issue for this to not overload this thread, let's continue discussing this in #580

mvz commented 8 years ago

I still think we'll get super confused by linking closed issues.

troessner commented 8 years ago

Closing this one to keep our issues nice and tidy. All interesting smell detectors have their separate tickets.