search

troessner / reek

Code smell detector for Ruby
https://github.com/troessner/reek
MIT License
4.05k stars 280 forks source link

Run Reek against rubyspec #757

Open troessner opened 9 years ago

troessner commented 9 years ago

I recently had a chat with @mbj and he suggested the following:

Also I run all checkins for mutants generation engine and unparsers round trip against rubyspec that is a great entropy source. Reek should do the same, maybe disabling reporting / state tracking. Just walking the AST with the engine and making sure it does not crash. Its a great invariant.

I think that's an excellent idea, let's do this.

WDYT?

chastell commented 9 years ago

:+1:

mvz commented 9 years ago

:+1:

troessner commented 9 years ago

I'm blocked the next weeks unfortunately, would anybody else like to tackle this?

mbj commented 9 years ago

I have a special test support class for the managing of corpus tests, that might be adaptable for you It assumes you have "many" projects you want to corpus test against: https://github.com/mbj/mutant/blob/master/spec/support/corpus.rb

You likely do not want to use my morpher based "type safe" config loader.

Still this could serve as an example on how to do such a corpus test, I use this code for years already so I should have ironed out the traps that exist in the concept of a corpus test.

mbj commented 9 years ago

This is how the config file looks for mutant: https://github.com/mbj/mutant/blob/master/spec/integrations.yml