search

trofi / nix-guix-gentoo

Gentoo overlay for nix and guix functional package managers.
110 stars 9 forks source link

The GDK_PIXBUF_MODULE_FILE environment variable fix doesn't seem to be necessary anymore #27

Closed gagero closed 1 year ago

gagero commented 1 year ago

The bug was closed with a patch merged yesterday.

trofi commented 1 year ago

Good point!

Yeah, removing it sounds reasonable. Probably worth rephrasing README.md to still mention now to filter out leaked variables in general and past bug as an example to handle it.

gagero commented 1 year ago

Good idea. That also means that people who don't update their systems can fix it themselves too.

trofi commented 1 year ago

How about this update (just pushed): https://github.com/trofi/nix-guix-gentoo/commit/1c229256c5b82cb1025ab23010efcb235e231466

gagero commented 1 year ago

There's a small grammatical issue on line 124. The "from" should be replaced with a "should".

trofi commented 1 year ago

Good catch! Hopefully fixed by https://github.com/trofi/nix-guix-gentoo/commit/8189fb79515077c1ccacf5e12688fe1f416ecc3e

gagero commented 1 year ago

Great, thanks!