search

trofi / nix-guix-gentoo

Gentoo overlay for nix and guix functional package managers.
110 stars 9 forks source link

Hide nixbld users from sddm #41

Closed kurumushi closed 10 months ago

kurumushi commented 10 months ago

SDDM by default lists all users with uids between 1000 and 60000. This commit adds a config file placed in /etc/sddm.d which will instruct sddm to not display the nixbld[1-64] users.

The only change to the ebuild are commands to install the file (see at lines 172-174)

trofi commented 10 months ago

Thank you!

The change looks reasonable. I have two minor comments:

  1. Normally /etc/sddm.conf.d is available for users to place or update their files. If your idea is to allow users to edit the file then I suspect CONFIG_PROTECT= would also need to be added. Otherwise /usr/lib/sddm/sddm.conf.d might be a better place to put it (or is it /usr/share/sddm/sddm.conf.d in Gentoo?)
  2. Instead of hardcoding user count in the files/ I suggest generating it in the ebuild itself.

WDYT? If you don't feel comfortable doing it we can merge your change as is and I'll try to do them afterward.

kurumushi commented 10 months ago

You are completely correct about putting it in /usr/lib/sddm/sddm.conf.d There really shouldn't be any need for a user to edit it, so the system location is better. Didn't even cross my mind.

As far as the user count, it could be generated in the ebuild, but that would add a lot of unneeded complexity. It would need to detect which of the acct-user/nixbldXX packages are installed, and then add or remove each user entry individually from the config.

The nix ebuild hardcodes 64 users, so there's no way not to use 64 users unless you modify the ebuild. And also none of the users are meant to be logged in at all, so there's no harm in excluding all of them. I can't imagine a use case where you'd need to log into an individual nixbld account in a GUI. The only potential conflict would be if a user already has a nixbldXX account not related to nix, which is probably a very rare case.

So my opinion is that there's not much need to generate the config, but you're welcome to go for it if that's what you want.