search

trogdoro / xiki

A shell console with GUI features
http://xiki.org
Other
3.76k stars 207 forks source link

first pass dockerfile for setting up xiki in a docker container #106

Closed mattyw closed 8 years ago

mattyw commented 10 years ago

Added a docker file to build a container that installs xiki.

Xiki seems to get built and installs, and some commands seem to work (xiki ip) but other commands produce errors (xiki docs/faq)

Probably needs some work but I'm proposing it here to inspire others to take a look

yonkeltron commented 10 years ago

I think this is a pretty great addition and will test this independently right now. How do you propose one interacts with xiki? Should this Dockerfile also install emacs and such? Happy to help make that happen.

thaJeztah commented 10 years ago

I'm not sure, but I think that automated builds on Docker hub can automatically use the GitHub repository as 'build context'. If that's true, then installing / pulling the source from GitHub can be omitted from the Dockerfile, making it a bit cleaner, Not 100% sure tough.

mattyw commented 10 years ago

@yonkeltron I'm not really sure how best to interact because I haven't work that part out for myself yet. It would be great to have the dockerfile represent and minimum install - so if emacs (and vim) should be part of that it would be good. Can you point me at some instructions for setting up xiki and emacs so that I can test it out?

@thaJeztah I'll take a look at the build context on docker hub thanks for the suggestion. Any idea if it would work when not using the hub though? (i.e. just cloning the source and creating an image locally?

thaJeztah commented 10 years ago

I think the idea then will be similar; you have a local checkout of the repository. The Dockerfile can include a COPY line to copy files from the current directory into the container.

mattyw commented 10 years ago

@thaJeztah I've pushed those changes, it should use the local code now, thanks for the suggestion

thaJeztah commented 10 years ago

@mattyw nice! Will give it a spin once I'm behind my computer

yonkeltron commented 10 years ago

We could also have a cron job somewhere to build and push nighly images (tagged as such) to the docker index. @trogdoro any desire to help coordinate volunteer teams?

thaJeztah commented 10 years ago

@yonkeltron any reason why? Feels like re-inventing the wheel as docker provides this service out of the box; https://docs.docker.com/docker-hub/builds/#automated-builds

mattyw commented 10 years ago

@yonkeltron @thaJeztah is right. The automated-builds approach would be the best one to use. The intention of this pr was just to provide a simple way of having new users get a working xiki binary with minimal effort.

yonkeltron commented 10 years ago

Wow! I didn't know that was even a thing. Please forgive me, I see now how my earlier remark would have seen silly. Also, please accept my thanks for teaching me something new.

mattyw commented 10 years ago

@yonkeltron No problem! I'd not heard of it until I opened the url

thaJeztah commented 10 years ago

Yes, Docker providing such service is pretty awesome. The advantage of docker in general is that it will allow people to quickly test xiki without worrying about cluttering their computer :)

yonkeltron commented 10 years ago

Yeah, we use Docker internally at my workplace and it rocks. Had no idea that autobuild was a thing, though.

Ok, so where are we on this PR?

On Tue, Jul 29, 2014 at 11:28 AM, Sebastiaan van Stijn < notifications@github.com> wrote:

Yes, Docker providing such service is pretty awesome. The advantage of docker in general is that it will allow people to quickly test xiki without worrying about cluttering their computer :)

— Reply to this email directly or view it on GitHub https://github.com/trogdoro/xiki/pull/106#issuecomment-50492503.

Jonathan E. Magen http://www.yonkeltron.com GTALK: yonkeltron@gmail.com http://twitter.com/yonkeltron ב"ה

trogdoro commented 10 years ago

Nice work guys! Does someone want to do a remote pairing session / chat and walk me through this? I don't have any experience with Docker.

As a side note, having a general-purpose "docker" xiki command could be kind of awesome (several people have suggested that).

--Craig

On Tue, Jul 29, 2014 at 8:32 AM, Jonathan E. Magen <notifications@github.com

wrote:

Yeah, we use Docker internally at my workplace and it rocks. Had no idea that autobuild was a thing, though.

Ok, so where are we on this PR?

On Tue, Jul 29, 2014 at 11:28 AM, Sebastiaan van Stijn < notifications@github.com> wrote:

Yes, Docker providing such service is pretty awesome. The advantage of docker in general is that it will allow people to quickly test xiki without worrying about cluttering their computer :)

— Reply to this email directly or view it on GitHub https://github.com/trogdoro/xiki/pull/106#issuecomment-50492503.

Jonathan E. Magen http://www.yonkeltron.com GTALK: yonkeltron@gmail.com http://twitter.com/yonkeltron ב"ה

— Reply to this email directly or view it on GitHub https://github.com/trogdoro/xiki/pull/106#issuecomment-50493077.

mattyw commented 10 years ago

@trogdoro I'm no expert with docker. But I'd be happy to pair with you, there's other things I'd like to talk to you about as well not related to this pr

trogdoro commented 10 years ago

Email me offlist and we'll set up a time! First name dot last name at gmail.

--Craig

On Tue, Jul 29, 2014 at 4:00 PM, Matt Williams notifications@github.com wrote:

@trogdoro https://github.com/trogdoro I'm no expert with docker. But I'd be happy to pair with you, there's other things I'd like to talk to you about as well not related to this pr

— Reply to this email directly or view it on GitHub https://github.com/trogdoro/xiki/pull/106#issuecomment-50551249.