search

trogdoro / xiki

A shell console with GUI features
http://xiki.org
Other
3.76k stars 208 forks source link

Resolve xiki_dir even if xsh is symlinked #134

Closed kalkin closed 8 years ago

kalkin commented 9 years ago

The current xsh shell script can not resolve the $xiki_dir if symlinked, i.e. to ~/bin.

trogdoro commented 9 years ago

Ty for the fix! Let me discuss this with a security-minded friend who pairs with me on Xiki. I think following symlinks can sometimes open you up to security issues.

kalkin commented 9 years ago

@trogdoro Or you could just read the comments and follow the SO link provided. The code basically resolves the link until it's not a symlink. Perhaps I'm not security minded enough, but i do not see a way how to exploit it.