search

trogdoro / xiki

A shell console with GUI features
http://xiki.org
Other
3.76k stars 207 forks source link

Rpec task fix #41

Closed jc00ke closed 11 years ago

jc00ke commented 11 years ago

rake -vT blew up after initial bundle because later versions of RSpec removed Spec::Rake::SpecTask.

keithtom commented 11 years ago

I'd consider using the gemfile.lock to specify the version. see https://github.com/trogdoro/xiki/pull/40

jc00ke commented 11 years ago

You can specify the version in the gemspec, which seems to be a common practice. Avoids the lock file.

mkb commented 11 years ago

Checking in Gemfile.lock is problematic for gems since generally they try to support multiple versions of Ruby. Best to deal with versioning in the gemspec.

In any case: :thumbsup:

keithtom commented 11 years ago

yep my bad, sounds good now :+1: