troglobit / editline

A small replacement for GNU readline() for UNIX
https://troglobit.com/projects/editline/
Other
282 stars 58 forks source link

handle home and end keys in urxvt #54

Closed tejing1 closed 3 years ago

tejing1 commented 3 years ago

urxvt uses \e[7~ and \e[8~ for home and end, respectively. (where \e is ASCII 0x1b) Currently these keys just type a ~ in an editline-based program running in urxvt, which is incredibly frustrating for me as I use these keys habitually. I've tested this, though not at all extensively, by rebuilding nix 2.4 to link against it and trying it in urxvt, xterm, and alacritty. I observed no problems.

tejing1 commented 3 years ago

Sorry for the confusion, didn't realize that would close the PR.

troglobit commented 3 years ago

Have you tested this patch with any other terminal, like gnome terminal (libvte), regular xterm, rxvt?

tejing1 commented 3 years ago

Have you tested this patch with any other terminal, like gnome terminal (libvte), regular xterm, rxvt?

Yes, as I stated in the OP, I tested with urxvt, xterm, and alacritty. I observed no problems, but I can't really call my testing "thorough" either.