troglobit / finit

Fast init for Linux. Cookies included
https://troglobit.com/projects/finit/
MIT License
622 stars 61 forks source link

Missing hook for HOOK_NETWORK_DOWN? #319

Closed hongkongkiwi closed 1 year ago

hongkongkiwi commented 1 year ago

I notice that there is a hook for HOOK_NETWORK_UP, however there's no hook for HOOK_NETWORK_DOWN

I see that this is actually a step during shutdown

[ OK ] Taking down network interfaces ...

Just wondering if this was intentional or an accident? I don't need this hook, but just thought I'd check.

troglobit commented 1 year ago

This was actually by design, at least initially, before we changed things around so network up/down runs in the background (relying on net/ conditions to synchronize services).

Now that both up and down run in the background I guess we can add an async hook also for HOOK_NETWORK_DN. Thanks for bringing it to my attention!