search

troglobit / finit

Fast init for Linux. Cookies included
https://troglobit.com/projects/finit/
MIT License
621 stars 61 forks source link

configure.ac: make cgroup2 configurable #406

Closed liuming50 closed 1 month ago

liuming50 commented 1 month ago

We would like cgroup2 to be configurable at build time, when it's disabled, finit will not check /sys/fs/cgroup for cgroup2 support.

The reason for why we need this is because we'd like to use our own rules for controlling cgroup2, and it's hard to adapt to finit's default settings.

troglobit commented 1 month ago

Looks OK overall, but I don't want to break the default, so please flip the setting to --disable-cgroups so it doesn't hit users upgrading.

liuming50 commented 1 month ago

@troglobit thanks for the review! Have changed it to "--disable-cgroup2" in V2 patch set.

liuming50 commented 1 month ago

@troglobit > Made some minor changes: ordering and simplify naming + help text. Hope that's OK with you?

Sure, thanks for the modification!

troglobit commented 1 month ago

Alright, thanks for taking the time to improve Finit! 😃🙏